Skip to content

[PWGCF] Use const& and std::move to avoid copies - #17706

Open
vkucera wants to merge 3 commits into
AliceO2Group:masterfrom
vkucera:const-PWGCF
Open

[PWGCF] Use const& and std::move to avoid copies#17706
vkucera wants to merge 3 commits into
AliceO2Group:masterfrom
vkucera:const-PWGCF

Conversation

@vkucera

@vkucera vkucera commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Mostly done automatically by Clang-Tidy.

@vkucera
Use const& and std::move to avoid copies
5925580 
Mostly done automatically by Clang-Tidy.
@github-actions github-actions Bot added the pwgcf label Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 1637 errors, ⚠️ 2064 warnings, 🔕 49 disabled

@github-actions github-actions Bot changed the title Use const& and std::move to avoid copies [PWGCF] Use const& and std::move to avoid copies Sep 1, 2026
@vkucera
vkucera marked this pull request as ready for review September 1, 2026 15:54
prchakra
prchakra previously approved these changes Sep 1, 2026
View reviewed changes
@alibuild

alibuild commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5925580 at 2026-09-02 01:10:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1156 errors and 4987 warnings.'
Found 1156 errors and 4987 warnings.
++ [[ 1156 -gt 0 ]]
++ cat /sw/BUILD/3bf59b7649317a1d44f95a54e9c167a2fa229c16/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/NetProtonCumulants.cxx:60:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/NetProtonCumulants.cxx:188:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:63:9: error: variadic macro 'FILL_QA_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:68:9: error: variadic macro 'FILL_QA_HIST_2D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:73:9: error: variadic macro 'ADD_QA_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:77:9: error: variadic macro 'ADD_QA_HIST_2D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:82:9: error: variadic macro 'ADD_PT_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:90:9: error: variadic macro 'FILL_PT_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:96:8: error: constructor does not initialize these fields: ccdb, fPhiCutExpPosHigh, fPhiCutExpPosLow, fPhiCutExpNegHigh, fPhiCutExpNegLow, funcCutEventsByMultPVvsV0A, funcCutEventsByMultPVvsT0C, funcCutEventsByMultPVvsV0A_anotherTrend [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:581:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:705:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:706:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:934:63: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:946:70: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1156:18: error: narrowing conversion from 'double' to 'int64_t' (aka 'long') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1160:7: error: Value stored to 'magneticField' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2210:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2230:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2241:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2241:33: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:55:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:56:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:57:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:58:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:59:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:61:9: error: macro 'BIT_IS_K0S' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:62:9: error: macro 'BIT_IS_LAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:63:9: error: macro 'BIT_IS_ANTILAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:67:9: error: macro 'BIT_POS_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:68:9: error: macro 'BIT_NEG_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:69:9: error: macro 'BIT_BOTH_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

EmilGorm
EmilGorm previously approved these changes Sep 2, 2026
View reviewed changes
@vkucera
vkucera dismissed stale reviews from EmilGorm and prchakra via 98cc4b7 September 4, 2026 15:21
@alibuild

alibuild commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 98cc4b7 at 2026-09-04 17:25:

No log files found

Full log here.

@alibuild

alibuild commented Sep 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 98cc4b7 at 2026-09-05 12:26:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1145 errors and 4974 warnings.'
Found 1145 errors and 4974 warnings.
++ [[ 1145 -gt 0 ]]
++ cat /sw/BUILD/7d59e971a6f2ff743b2304ea97931b8493ab4c16/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/NetProtonCumulants.cxx:60:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/NetProtonCumulants.cxx:188:8: error: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:63:9: error: variadic macro 'FILL_QA_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:68:9: error: variadic macro 'FILL_QA_HIST_2D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:73:9: error: variadic macro 'ADD_QA_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:77:9: error: variadic macro 'ADD_QA_HIST_2D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:82:9: error: variadic macro 'ADD_PT_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:90:9: error: variadic macro 'FILL_PT_HIST_1D' used; consider using a 'constexpr' variadic template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:96:8: error: constructor does not initialize these fields: ccdb, fPhiCutExpPosHigh, fPhiCutExpPosLow, fPhiCutExpNegHigh, fPhiCutExpNegLow, funcCutEventsByMultPVvsV0A, funcCutEventsByMultPVvsT0C, funcCutEventsByMultPVvsV0A_anotherTrend [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:581:49: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:705:59: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:706:53: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:934:63: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:946:70: error: result of integer division used in a floating point context; possible loss of precision [bugprone-integer-division,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1156:18: error: narrowing conversion from 'double' to 'int64_t' (aka 'long') [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1160:7: error: Value stored to 'magneticField' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2210:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2230:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2241:15: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:2241:33: error: narrowing conversion from 'double' to 'bool' [bugprone-narrowing-conversions,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:55:9: error: macro 'ID_BIT_PI' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:56:9: error: macro 'ID_BIT_KA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:57:9: error: macro 'ID_BIT_PR' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:58:9: error: macro 'ID_BIT_EL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:59:9: error: macro 'ID_BIT_DE' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:61:9: error: macro 'BIT_IS_K0S' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:62:9: error: macro 'BIT_IS_LAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:63:9: error: macro 'BIT_IS_ANTILAMBDA' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:67:9: error: macro 'BIT_POS_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:68:9: error: macro 'BIT_NEG_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:69:9: error: macro 'BIT_BOTH_DAU_HAS_SAME_COLL' used to declare a constant; consider using a 'constexpr' constant [cppcoreguidelines-macro-usage,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:71:9: error: function-like macro 'BITSET' used; consider a 'constexpr' template function [cppcoreguidelines-macro-usage,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@alibuild

alibuild commented Sep 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0c00671 at 2026-09-14 05:43:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 59 errors and 5612 warnings.'
Found 59 errors and 5612 warnings.
++ [[ 59 -gt 0 ]]
++ cat /sw/BUILD/6a54d4612a837a52c4de01c577842e432837fea5/O2Physics-code-check/errors.txt
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:714:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:715:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:717:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:718:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:720:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:721:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:723:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:724:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:726:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:727:9: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/RobustFluctuationObservables.cxx:1160:7: error: Value stored to 'magneticField' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2330:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/EbyEFluctuations/Tasks/kaonIsospinFluctuations.cxx:2451:7: error: Value stored to 'centrality' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:633:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackNucleus.cxx:666:7: error: Value stored to 'fillQA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/Flow/Tasks/flowEsePHe3.cxx:1099:51: error: both sides of operator are equivalent [misc-redundant-expression,-warnings-as-errors]
PWGCF/Flow/Tasks/flowEsePHe3.cxx:1100:53: error: both sides of operator are equivalent [misc-redundant-expression,-warnings-as-errors]
PWGCF/Flow/Tasks/flowEsePHe3.cxx:1101:53: error: both sides of operator are equivalent [misc-redundant-expression,-warnings-as-errors]
PWGCF/Flow/Tasks/flowTask.cxx:1114:9: error: Branch condition evaluates to a garbage value [clang-analyzer-core.uninitialized.Branch,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:419:23: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:530:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:712:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:785:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:817:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:835:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:871:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:889:3: error: Potential leak of memory pointed to by 'nam' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:949:10: error: Potential leak of memory pointed to by 'l_bins' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/FlowContainer.cxx:1240:10: error: Potential leak of memory pointed to by 'retBins' [clang-analyzer-cplusplus.NewDeleteLeaks,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFWCumulant.cxx:97:5: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFWWeights.cxx:176:14: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFWWeights.cxx:309:5: error: Opened stream never closed. Potential resource leak [clang-analyzer-unix.Stream,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFWWeights.cxx:329:19: error: Value of 'errno' was not checked and may be overwritten by function 'fscanf' [clang-analyzer-unix.Errno,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:61:13: error: std::move of the const variable 'refName' has no effect; remove std::move() or make the variable non-const [performance-move-const-arg,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:66:28: error: the parameter 'refName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:70:5: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:71:13: error: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:73:28: error: the parameter 'refName' is copied for each invocation but only used as a const reference; consider making it a const reference [performance-unnecessary-value-param,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:77:5: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:78:13: error: passing result of std::move() as a const reference argument; no move will actually happen [performance-move-const-arg,-warnings-as-errors]
PWGCF/GenericFramework/Core/GFW.cxx:121:5: error: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Core/EventSelectionFilterAndAnalysis.cxx:167:5: error: Call to virtual method 'EventSelectionFilterAndAnalysis::StoreArmedMask' during construction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator Author

Ping

@vkucera

vkucera commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

Dear @lauraser @dsarkaralice, this PR has been opened for review for more than two weeks. I would appreciate if it could be reviewed by the relevant code owners soon. Thank you.

@dsarkaralice
dsarkaralice enabled auto-merge (squash) September 17, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaelpark jaelpark jaelpark approved these changes
@prchakra prchakra prchakra approved these changes
@SwatiSaha-1997 SwatiSaha-1997 SwatiSaha-1997 approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern ariedel-cern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@abilandz abilandz Awaiting requested review from abilandz abilandz is a code owner
@majanik majanik Awaiting requested review from majanik majanik is a code owner
@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern lgraczykCern is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner
@glromane glromane Awaiting requested review from glromane glromane is a code owner
@sofiatomassini sofiatomassini Awaiting requested review from sofiatomassini sofiatomassini is a code owner
@isputows isputows Awaiting requested review from isputows isputows is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@EmilGorm EmilGorm Awaiting requested review from EmilGorm EmilGorm is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vkucera @alibuild @jaelpark @prchakra @EmilGorm @SwatiSaha-1997